Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iss #308 fixed speed and direction coverage and added test #320

Merged
merged 1 commit into from
Jan 19, 2022
Merged

iss #308 fixed speed and direction coverage and added test #320

merged 1 commit into from
Jan 19, 2022

Conversation

BiancaMorandi
Copy link
Contributor

@BiancaMorandi BiancaMorandi commented Jan 17, 2022 •
edited

iss #308

  • fixed speed and direction coverage issue
  • added test for scenario when target speed or direction is present and reference is not. Note that the test is failing when target direction is present and reference is not...this is due to iss [average_data_by_period] Bug on wind direction average derivation #319 . When this issue will be solved then this test will be successful.

@BiancaMorandi BiancaMorandi added the bug Something isn't working label Jan 17, 2022
@BiancaMorandi BiancaMorandi self-assigned this Jan 17, 2022
@BiancaMorandi BiancaMorandi added this to In progress in brightwind kanban Jan 17, 2022
@BiancaMorandi BiancaMorandi moved this from In progress to Awaiting Approval in brightwind kanban Jan 19, 2022
@stephenholleran stephenholleran merged commit b30a079 into dev Jan 19, 2022
@stephenholleran stephenholleran deleted the iss308_fix_speed_sort_coverage branch January 19, 2022 14:58
@BiancaMorandi BiancaMorandi moved this from Awaiting Approval to Done in brightwind kanban Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenholleran stephenholleran stephenholleran approved these changes

Assignees

@BiancaMorandi BiancaMorandi

Labels
bug Something isn't working
Projects
brightwind kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BiancaMorandi @stephenholleran