Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[average_data_by_period] Bug on wind direction average derivation #319

Closed
BiancaMorandi opened this issue Jan 17, 2022 · 1 comment
Closed

[average_data_by_period] Bug on wind direction average derivation #319

BiancaMorandi opened this issue Jan 17, 2022 · 1 comment
Assignees
@BiancaMorandi
Labels
bug Something isn't working
Projects
brightwind kanban

Comments

@BiancaMorandi
Copy link
Contributor

BiancaMorandi commented Jan 17, 2022 •
edited

average_data_by_period of wind direction for a period equal to the timestamp is not returning the same as the input wind direction. Same speed values are returned instead. See example below.
image
@BiancaMorandi BiancaMorandi added the bug Something isn't working label Jan 17, 2022
@BiancaMorandi BiancaMorandi self-assigned this Jan 17, 2022
This was referenced Jan 17, 2022
Merged
Merged
@BiancaMorandi BiancaMorandi moved this from To do to Backlog in brightwind kanban Feb 8, 2022
@BiancaMorandi BiancaMorandi moved this from Backlog to To do in brightwind kanban Jul 18, 2022
BiancaMorandi added a commit that referenced this issue Sep 8, 2022
@BiancaMorandi
iss #319 fix bug for direction average
7869ac3
@BiancaMorandi
Copy link
Contributor Author

BiancaMorandi commented Sep 8, 2022 •
edited

this bug is fixed as shown in screenshot below.
image

This bug fix is impacting the bw.Corr.SpeedSort() and bw.Correl.synthesize() results because average wind direction for a period equal to the timestamp is now equal to input direction. - this is why test_correlation.py has been updated as part of this bug. The impact of this bug fix is minor as it can be observed from results of test below.
image

BiancaMorandi added a commit that referenced this issue Sep 8, 2022
@BiancaMorandi
iss #319 fixed tests speedsort and synth
ba1a94b
BiancaMorandi added a commit that referenced this issue Sep 8, 2022
@BiancaMorandi
iss #319 updated chnagelog file
bf0ddad
@BiancaMorandi BiancaMorandi mentioned this issue Sep 8, 2022
Merged
@BiancaMorandi BiancaMorandi moved this from To do to Awaiting Approval in brightwind kanban Sep 8, 2022
@stephenholleran stephenholleran moved this from Awaiting Approval to In progress in brightwind kanban Sep 13, 2022
@stephenholleran stephenholleran moved this from In progress to Done in brightwind kanban Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BiancaMorandi BiancaMorandi

Labels
bug Something isn't working
Projects
brightwind kanban
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenholleran @BiancaMorandi