Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss #304 speedsort fix variable names #321

Merged
merged 9 commits into from
Feb 25, 2022

Conversation

BiancaMorandi
Copy link
Contributor

@BiancaMorandi BiancaMorandi commented Jan 20, 2022

Issue #304

  • solved issue when same windspeed or same direction are given as the reference and the target..issue solved for all correlation functions as fix done for CorrelBase
  • added general function in utils to _rename_equal_elements_between_two_inputs
  • fixed issue for MultipleLinearRegression function. The original pd.Series names were changed when the list of input reference pd.Series had the same name. Fixed the code to change the name if only pd.Series used in the function.
  • added tests for this and added test_utils.py file
    Note that 2 tests for speedSort synthesize are giving an error due to issue [average_data_by_period] Bug on wind direction average derivation #319

@BiancaMorandi BiancaMorandi added the bug Something isn't working label Jan 20, 2022
@BiancaMorandi BiancaMorandi self-assigned this Jan 20, 2022
@BiancaMorandi BiancaMorandi added this to Awaiting Approval in brightwind kanban Jan 20, 2022
@BiancaMorandi
Copy link
Contributor Author

BiancaMorandi commented Feb 1, 2022

as for Stephen's review to do:

  • move if statements inside CorrelBase into new function
  • rename all input1 names adding suffix (not only the duplicate one) - _rename_equal_elements_between_two_inputs
  • remove default None to input1_suffix inside _rename_equal_elements_between_two_inputs function
  • compare only lists and not str (can accept str but then it is converted to list of 1 element) - _rename_equal_elements_between_two_inputs

@BiancaMorandi
Copy link
Contributor Author

@stephenholleran I made the changes you have requested. Happy to discuss.

@BiancaMorandi
Copy link
Contributor Author

BiancaMorandi commented Feb 8, 2022

  • Move _rename_equal_elements_between_two_inputs inside correlation.py
  • remove all errors raised
  • move convert string to list to function inside CorreBase
  • remove all tests in utils

@BiancaMorandi
Copy link
Contributor Author

BiancaMorandi commented Feb 8, 2022

@stephenholleran I made all the updates you have requested. The test_correlation.py should raise two errors. This is normal as the errors are due to issue #319

@stephenholleran stephenholleran merged commit f020394 into dev Feb 25, 2022
@stephenholleran stephenholleran deleted the iss304_speedsort_fix_variable_names branch February 25, 2022 18:43
@stephenholleran stephenholleran moved this from Awaiting Approval to Done in brightwind kanban Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants