-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iss #304 speedsort fix variable names #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as for Stephen's review to do:
|
@stephenholleran I made the changes you have requested. Happy to discuss. |
|
@stephenholleran I made all the updates you have requested. The test_correlation.py should raise two errors. This is normal as the errors are due to issue #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #304
CorrelBase
utils
to_rename_equal_elements_between_two_inputs
MultipleLinearRegression
function. The original pd.Series names were changed when the list of input reference pd.Series had the same name. Fixed the code to change the name if only pd.Series used in the function.Note that 2 tests for speedSort synthesize are giving an error due to issue [average_data_by_period] Bug on wind direction average derivation #319