[Iss386] freq table basic coverage thresh #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_coverage_threshold
…on_coverage_threshold function common to momm
…hreshold text in order to work for both momm and freq table functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following updates to
freq_table:_filter_out_months_based_on_coverage_thresholdfunction generated as part of [MOMM] add weighting to calculation #298. Warning messages for data coverage generated formommandfreq_tableare now generated by same function and therefore similar.var_seriesanddirection_seriesdata when a coverage_threshold is given as input - this was a bug in previous version as coverage filter was based only onvar_seriescoverage_thresholdalso for the basic method and not only for seasonal adjusted option. Similarly tomomm([MOMM] add weighting to calculation #298), I have updated thecoverage_thresholddefault value to be None when no seasonal adj is applied and 0.8 with seas adj. This was done in order to avoid generating a breaking change.