[BR-24456] Fix shadowRoot issues by updating to 14.2.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Accessibility: added additional keyboard shortcuts: page up / page down to move slider handle in larger steps than with up/down and left / right keys (ratio 5x) and home / end keys to move slider handle between min / max values (range).
Invert ltr direction check to rtl to match defaults, addressing the case where the computed style doesn't yet contain a direction. Partial fix for leongersen#1038.
Invert direction check logic
* Create composer.json Co-authored-by: Anton Kiyatkin <axlbant@sent.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.1.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ould be shown at end of range (leongersen#1063) * Fix issue where the last pip gets incorrect type when there is only one pip value displayed at the end of range * Add test for edge case where a single pip value at the end of range is not drawn correctly
* Add slider public api to callback parameter Useful when 'this' is unavailable in a Typescript environment when you set up the callback with a arrow function to access the calling class. * Add noUiSlider parameter to onEvent * documentation add missing parameter definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues with dragging sliders in V3-migrated courses. This appears to stem from this issue, which was fixed in noUISlider 14.2.