This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Add Zeek scripts for JA3 and HASSH (via zkg) (NOT YET FOR MERGE!) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henridf
approved these changes
Apr 28, 2020
philrz
changed the title
|
This one is deemed ready to go, but we're intentionally holding off on merging it because this PR currently only affects our Zeek artifacts for Linux/Mac and the plan for Windows is still in flux pending the resolution of #14. Therefore I'll hold this one open until we have a plan to cover all our platforms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the review comments of #18, in this PR we install the Zeek scripts for JA3 and HASSH via Zeek Package Manager. For each script, the URL and commit hash of what gets installed is included as a comment in
local.zeekalongside the@loadcommand that invokes it.If this is approved, I'll push one more commit to undo the Actions workflow before I merge.