This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
modify scripts and commands that run zeek #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2020
alfred-landrum
commented
May 5, 2020
|
Ready for review: I've got PR's open in zq & brim that show pcap ingest works, using the artifact from this PR (including making a manual artifact for windows using this code). |
nwt
approved these changes
May 7, 2020
alfred-landrum
force-pushed
the
add-zeek-args
branch
from
b28527d
to
fa3be59
Compare
alfred-landrum
added a commit
to brimdata/zed
that referenced
this pull request
May 8, 2020
The cli options used when launching zeek are removed, and will be managed in the zeek repo ( brimdata/zeek#23 ). The zqd cli option to specify a zeek runner is -zeekrunner, which should either be a full path to a command or the name of a command available in PATH.
alfred-landrum
added a commit
to brimdata/zui
that referenced
this pull request
May 8, 2020
This is part of the brimsec/brim repo side work for #731. Use the -zeekrunner cli option to zqd ( brimdata/zed#718 ), defaulting to the value of environment variable BRIM_ZEEK_RUNNER, else to the zeekrunner included from the zdeps zeek artifact ( brimdata/zeek#23 ).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the brimsec/zeek repo side of brimdata/zui#731.
The script (mac/linux) or executable (windows) that runs Zeek, including creating required environment variables & command line options, is now
zeekrunnerorzeekrunner.exe. The command line options used to run Zeek are now here in this repo instead of in the zqd source. The job object based process termination for windows is removed, as it is moved into zqd; this will make it easier to eventually replace the windows zeek runner with a script or batch file.