change zqd option to specify zeek runner #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfred-landrum
force-pushed
the
remove-zeek-args
branch
from
3dab62b
to
d5bdd6b
Compare
alfred-landrum
force-pushed
the
zeek-jobobj
branch
from
78098df
to
1ee2e8e
Compare
alfred-landrum
force-pushed
the
remove-zeek-args
branch
from
d5bdd6b
to
590a0fa
Compare
alfred-landrum
commented
May 5, 2020
alfred-landrum
force-pushed
the
remove-zeek-args
branch
from
590a0fa
to
2075fcb
Compare
mattnibs
reviewed
May 7, 2020
Comment on lines
-15
to
-24
| // ExecScript will be fed into a launched zeek process as the --exec option. The | ||
| // default script disables the packet_filter and loaded scripts logs. These logs | ||
| // are disabled because the emit either timeless logs or logs with timestamp | ||
| // set to execution time rather than time of capture. | ||
| var ExecScript = ` | ||
| event zeek_init() { | ||
| Log::disable_stream(PacketFilter::LOG); | ||
| Log::disable_stream(LoadedScripts::LOG); | ||
| }` | ||
|
|
There was a problem hiding this comment.
Given that we're getting rid of this, is the api able to handle timeless points? Do we have a test for this?
There was a problem hiding this comment.
We're still using this setup, but it's moved (like the zeek command line arguments) into the zeekrunner script; see brimdata/zeek#23.
alfred-landrum
force-pushed
the
remove-zeek-args
branch
from
2075fcb
to
96b4582
Compare
henridf
approved these changes
May 8, 2020
alfred-landrum
added a commit
to brimdata/zui
that referenced
this pull request
May 8, 2020
This is part of the brimsec/brim repo side work for #731. Use the -zeekrunner cli option to zqd ( brimdata/super#718 ), defaulting to the value of environment variable BRIM_ZEEK_RUNNER, else to the zeekrunner included from the zdeps zeek artifact ( brimdata/zeek#23 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the brimsec/zq repo side of brimdata/zui#731.
The cli options used when launching zeek are removed, and will be managed in the zeek repo ( brimdata/zeek#23 ).
The zqd cli option to specify a zeek runner is
-zeekrunner, which should either be a full path to a command or the name of a command available in PATH.