Failures due to "Reset State"

[philrz]

Repro is with Zui Insiders 1.0.2-29. I was also able to reproduce this problem with the most recent GA release Zui 1.0.1.

It seems like the Reset State option in the Window pull-down menu has been broken for a while. In the attached video I start out with some loaded data, query history, and a saved query. When I select Reset State nothing seems to happen. I open the DevTools console and select Reset State again and confirm that no error shows up. I then quit the app entirely and it immediately appears to relaunch twice, and clicking on one of them reveals a stack dump:

Uncaught Exception:
Error: The 'screen' module can't be used before the app 'ready' event
at createScreenIfNeeded (node:electron/js2c/browser_init:2:53651)
at Object.get (node:electron/js2c/browser_init:2:53693)
at Object.getDisplays (/Applications/Zui - Insiders.app/Contents/Resources/app.asar/dist/js/electron/windows/get-displays.js:8:29)
at SearchWindow.init (/Applications/Zui - Insiders.app/Contents/Resources/app.asar/dist/js/electron/windows/zui-window.js:22:115)
at Object.createWindow (/Applications/Zui - Insiders.app/Contents/Resources/app.asar/dist/js/electron/windows/create.js:23:58)
at WindowManager.create (/Applications/Zui - Insiders.app/Contents/Resources/app.asar/dist/js/electron/windows/window-manager.js:39:43)
at App.<anonymous> (/Applications/Zui - Insiders.app/Contents/Resources/app.asar/dist/js/electron/initializers/window-events.js:38:26)
at App.emit (node:events:513:28)

Repro.mp4

I did a Dev mode binary search to see if I could confirm where this started breaking and I converged on the existing issue #2627. Maybe there's more layers of breakage hiding behind that one, but maybe that's a good place to start.

[philrz]

Verified in Zui Insiders 1.0.2-31.

As shown in the attached video, now when I select Reset State and click Ok the app immediately restarts in a cleared state.

Verify.mp4

Thanks @jameskerr!