Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit the app after relaunch #2767

Merged
merged 2 commits into from
May 10, 2023
Merged

Exit the app after relaunch #2767

merged 2 commits into from
May 10, 2023

Conversation

jameskerr
Copy link
Member

@jameskerr jameskerr commented May 9, 2023 •
edited

Fixes #2765

philrz
philrz approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested out the fix in this branch using the Dev build from https://github.com/brimdata/zui/actions/runs/4941657945. As the attached video shows, the problem seems to be addressed, so that's a 👍 for me.

Verify.mp4

@jameskerr jameskerr merged commit 2082c17 into main May 10, 2023
6 of 9 checks passed
@jameskerr jameskerr deleted the reset-state-fix branch May 10, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failures due to "Reset State"
2 participants
@jameskerr @philrz