-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zui with No Tabs Open #2797
Zui with No Tabs Open #2797
Conversation
This is now handed by the Results and Histogram slices
This comment was marked as resolved.
This comment was marked as resolved.
I'm prepping to do some testing of what happens when upgrading from the last GA Zui release v1.1.0 to Dev builds based on this branch, as I want to fully understand what happens to details like editor contents, History, etc. after upgrade. As the old design made it somewhat difficult to even get to a state with connections to different lakes in different tabs, I've settled on a a consistent recipe that gets me into that as my "before upgrade" state. Therefore I'm describing & showing that in this comment and will refer back to it in other comments where I cite problems I might find after upgrading to a Dev build from this "before" state. The steps described in text:
Prep.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
When you load from sidebar, new tab, when you load from new pool page, replace url.
In order to achieve this, we had to make these changes.
The "url" for each tab was previously prefixed with
/lake/:id
. This had to be removed, and a migration created to migrate all the urls saved in the state. The routes have been updated to reflect this as well.A window will only be able to connect to one lake at a time. This is like how slack and vscode have designed their apps. Their "workspaces" are the equivalent of our "lakes". You can have multiple windows connected to different lakes though. Wrote migration to set the lake id to whatever the lake id in the last opened tab.
Remove the constraint of having 1 tab always open.
Create a view for when there are no tabs open. Right now it's just the big zed logo background image.
Assign the tabs to a lake. When switching lakes, the tabs for the previous lake will be saved and hidden. When switching back, they will be restored.
Extras:
Questions Found To Follow Up?
Do we need the errors reducer anymore?
Do we need the URL reducer??
Do we need the toolbars reducer anymore??
Closes #2249