Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app to have no tabs open #2249

Closed
jameskerr opened this issue Mar 5, 2022 · 3 comments · Fixed by #2797
Closed

Allow app to have no tabs open #2249

jameskerr opened this issue Mar 5, 2022 · 3 comments · Fixed by #2797
Assignees
Labels
bug Something isn't working

Comments

@jameskerr
Copy link
Member

Let's be more like vscode than google chrome. Since our sidebar offers alot of navigation, let's allow a state where there are no tabs open. The user can still click pools and queries in the sidebar.

@jameskerr jameskerr added the bug Something isn't working label Mar 5, 2022
@mason-fish
Copy link
Contributor

@jameskerr did you have an empty state in mind to fill the main page in this tabless scenario?

@jameskerr
Copy link
Member Author

I just took a swing at this and missed. Here are my thoughts for the next attempt.

Much of the app depends on a tab being active. We'd need the whole sidebar and app wrapper components to have no dependencies on state from the "active tab".

@philrz
Copy link
Contributor

philrz commented Jul 18, 2023

Verified in Zui commit 05f017b.

The linked PR #2797 changed more than just allowing for the app to have no tabs open. Now each window will only be able to connect to one lake at a time, so as shown in the attached video, changing the lake connection in the drop-down menu changes the tabs shown to the ones previously established when connected to that lake. The video also shows how the app does indeed now allow all tabs to be closed. When in that "no tabs" state, currently just the big Zed logo background image is shown in the large/blank area, so #2804 has been opened to remind us to put something more helpful there eventually.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants