Monaco Editor In Zui #2824
Merged
Monaco Editor In Zui #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Jul 28, 2023
Comment on lines
+4
to
+23
| "uint8", | ||
| "uint16", | ||
| "uint32", | ||
| "uint64", | ||
| "int8", | ||
| "int16", | ||
| "int32", | ||
| "int64", | ||
| "float16", | ||
| "float32", | ||
| "float64", | ||
| "bool", | ||
| "string", | ||
| "duration", | ||
| "time", | ||
| "bytes", | ||
| "ip", | ||
| "net", | ||
| "type", | ||
| "null", |
There was a problem hiding this comment.
The Zed types in zed-js (e.g, TypeOfUint8) have a name property. Would it make sense to use those name properties here?
| const isEnterKey = e.key === "Enter" | ||
| const isModKey = e.shiftKey || cmdOrCtrl(e) | ||
| if (isEnterKey) { | ||
| if ((runOnEnter && !isModKey) || (!runOnEnter && isModKey)) { |
There was a problem hiding this comment.
Maybe simplify this?
Suggested change
| if ((runOnEnter && !isModKey) || (!runOnEnter && isModKey)) { | |
| if (runOnEnter !== isModKey) { |
There was a problem hiding this comment.
That's too smart for me. 😅
nwt
approved these changes
Jul 28, 2023
philrz
approved these changes
Jul 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced code mirror with Monaco. This PR includes some minimal syntax highlighting.
CleanShot.2023-07-27.at.16.52.05.mp4
Closes #2812
Closes #2762