Recommend absolute paths for rewrite targets (#59)

Fixes #58.
bripkens · Jan 8, 2019 · e931cce · e931cce
1 parent a09b9e0
commit e931cce
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## v1.5.1
+ - Recommend absolute paths for rewrite targets. Contributed by @helfi92.
+
 ## v1.5.0
  - Expose the HTTP request object in rewrite rules. Contributed by @VladShcherbin.
 

diff --git a/lib/index.js b/lib/index.js
@@ -50,6 +50,17 @@ exports = module.exports = function historyApiFallback(options) {
       var match = parsedUrl.pathname.match(rewrite.from);
       if (match !== null) {
         rewriteTarget = evaluateRewriteRule(parsedUrl, match, rewrite.to, req);
+
+        if(rewriteTarget.charAt(0) !== '/') {
+          logger(
+            'We recommend using an absolute path for the rewrite target.',
+            'Received a non-absolute rewrite target',
+            rewriteTarget,
+            'for URL',
+            req.url
+          );
+        }
+
         logger('Rewriting', req.method, req.url, 'to', rewriteTarget);
         req.url = rewriteTarget;
         return next();