New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify paths to ignore #22
Conversation
Thanks for the PR! Before accepting this, I would like to understand why the existing rules do not cover your use case. This middleware is nowadays used by a larger number of users whose requirements probably aren't very different to yours. Specifically:
Why do these requests fail? I'd assume that these resources aren't redirected due to the rule:
|
One way to reproduce the problem is to run an app utilizing SystemJS without the proper mapping provided in the system config. our project's system-config looks very similar to the one found here. Provided that app is running with the |
Closing due to inactivity. |
This would be handy for me, as i have a mix of routes that have Server Rendering, and a few that dont. I have no way to get route parameters in express right now for routes that i dont want rewritten. Why not check to see if theres an existing route, and use that, instead of re-writing |
I would also like to +1 this. |
I just added a new sample app that explains how to do based on arbitrary HTTP parameters. Hope this resolve this for you folks. https://github.com/bripkens/connect-history-api-fallback/tree/master/examples/ignore-rules |
Thanks for the great library!
We're using this on an angular2 project right now embedded within a gulp script for our local
serve
task and it's working great. The one downside is that any requests to local resources that fail get redirected to the index page which often times results in a strange error having something to do with an unexpected<
character.This pull request adds the ability to configure some url patterns that if they exist in the URL being requested, the redirect to index does not happen.
The way it's implemented could result in not redirecting to index when you really wanted to but as it's opt-in via a configuration (The readme has been updated to reflect the new configuration item) I thought leaving it as wide open and configurable by the end user as possible would be a good thing.
Thoughts?
Thanks,
Randy