Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same as #27, but cleaned history #34

Merged
merged 17 commits into from
Nov 23, 2020
Merged

Same as #27, but cleaned history #34

merged 17 commits into from
Nov 23, 2020

Conversation

brisvag
Copy link
Owner

@brisvag brisvag commented Nov 23, 2020

We should close #27 and use this one. I did not clean up the two testing binaries because they have been in here for a long time, and I don't think it's a good idea to rewrite history that far in the past. We should just be careful not to do this again.

As we saud, we can then set up an examples repo for this stuff.

@brisvag brisvag changed the title Same as #27, but cleaned hidtory Same as #27, but cleaned history Nov 23, 2020
@brisvag
Copy link
Owner Author

brisvag commented Nov 23, 2020

Force-pushed a change that removes changes to the test data (they were re-generated, so github thought they were new files).
We should not regenerate test-data and push it every time!
I will add a gitignore for mrc and similar.

@alisterburt
Copy link
Collaborator

PR'd onto this with the working EulerAnglesHelper and working vector depiction

@brisvag brisvag merged commit 347c75a into brisvag:develop Nov 23, 2020
@brisvag brisvag mentioned this pull request Nov 24, 2020
@brisvag brisvag deleted the clean_bigfiles branch November 24, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants