-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TransformBlock and DipoleBlock objects #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at this code, I am a bit confused as to what DipoleBlock
, OrientedPointBlock
and TransformBlock
bring to the table. Arent all of these effectively just different ways of describing the same concept as ParticleBlock
?
Particles are just Dipoles/OrientedPoints with an additional Properties block... Why not use particles to describe Dipoles, or viceversa? And with our new Achemists
, now even TransformBlock
can simply be an Alchemist
that takes 2 particle-like objects and returns another ParticleBlock
...
I think that if we keep this concept abstract, we can avoid a lot of code duplication and confusing classes.
However, it makes sense to have a generic particles/dipoles/orientedpoint block without properties, and make ParticleBlock
a daughter class of that.
I agree with some but not all of what you've said, specifically...
Looking forward to hearing your thoughts! |
…deal with this again
I don't think it's a good idea to add big files like these example data files to the repo. I would prefer to host them separately, so we don't bog down this repo with heavy stuff. |
As we discussed, we will make a repo with example data. We need to be careful to remove these files from your branch's history, or we will still carry them around forever. |
#34 supersedes this. Closing. |
This PR adds
DipoleBlock
object for simple definition of oriented particlesTransformBlock
object which can store and apply 3D transformations onto existingParticleBlock
sand closes #14
It seems strange that
TransformBlock
inherits fromParticleBlock
and has to have properties, what do you think about adding anOrientedPointBlock
which would be a parent class to both of these?