Refactor write_test common parts + add map tests. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bit of repetitiveness in the tests comparing doing the same write / compare. This change refactors that into a helper function.
Methods added to test int keyed maps and string keyed maps.
rayhaanj
changed the title
britram
approved these changes
Feb 26, 2018
| 0x68, 0x02, 0x76, 0x43, 0x6F, 0x6E, 0x66, 0xC3, 0xA9, | ||
| 0x64, 0xC3, 0xA9, 0x72, 0x61, 0x74, 0x69, 0x6F, 0x6E, | ||
| 0x20, 0x53, 0x75, 0x69, 0x73, 0x73, 0x65}, | ||
| }, |
There was a problem hiding this comment.
quick Q: where was this vector generated?
There was a problem hiding this comment.
I used the web based converter at: http://cbor.me/ to generate those bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit of repetitiveness in the tests comparing doing the same write /
compare. This change refactors that into a helper function.
Also added a case for integer slices, and tests for
map[string]interface{},map[int]interface{}