Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating metadata #89

Merged
merged 2 commits into from
Oct 7, 2022
Merged

updating metadata #89

merged 2 commits into from
Oct 7, 2022

Conversation

dreymoreau
Copy link
Contributor

@dreymoreau dreymoreau commented Oct 7, 2022

made changes from issue #47

Describe your changes

made changes to the metadata :)

Link to issue this resolves

Screenshot of changes(if relevant)

  • [x ] The title should be something descriptive about what you're changes do. (It will default to whatever you put as your commit message.)
  • [x ] This description should include ...
    • A short summary of your changes
    • A link to the issue that relates to these changes
    • A screenshot of the changes if possible!
  • Add brittanyjoiner15 as a reviewer
  • Add yourself as assignee

made changes from issue #47
@vercel
Copy link

vercel bot commented Oct 7, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @brittanyjoiner15 on Vercel.

@brittanyjoiner15 first needs to authorize it.

Copy link
Owner

@brittanyjoiner15 brittanyjoiner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change EUI to Eui

@@ -5,12 +5,12 @@
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta property="og:title" content="Eui and React Event Site Template" data-rh="true">
<meta property="og:description" content="Use this template to create a single page website for your event! Includes format for speaker bios, agendas, even details and signup, and more!" data-rh="true">
<meta property="og:title" content="EUI and React Event Site Template" data-rh="true">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta property="og:title" content="EUI and React Event Site Template" data-rh="true">
<meta property="og:title" content="Eui and React Event Site Template" data-rh="true">

<meta property="og:title" content="Eui and React Event Site Template" data-rh="true">
<meta property="og:description" content="Use this template to create a single page website for your event! Includes format for speaker bios, agendas, even details and signup, and more!" data-rh="true">
<meta property="og:title" content="EUI and React Event Site Template" data-rh="true">
<meta property="og:description" content="Use React and EUI to create an event or conference website! This is a template with an example." data-rh="true">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta property="og:description" content="Use React and EUI to create an event or conference website! This is a template with an example." data-rh="true">
<meta property="og:description" content="Use React and Eui to create an event or conference website! This is a template with an example." data-rh="true">

<meta property="og:image" content="https://firebasestorage.googleapis.com/v0/b/photo-url-generator-e736c.appspot.com/o/posts%2Fd4enUaRMG4LSAv8BakmJ%2Fimage?alt=media&token=7bf82d2d-e779-49dc-81ab-440aa9cafe3c" data-rh="true">
<meta
name="description"
content="Use this template to create a single page website for your event! Includes format for speaker bios, agendas, even details and signup, and more!"
content="Use React and EUI to create an event or conference website! This is a template with an example."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
content="Use React and EUI to create an event or conference website! This is a template with an example."
content="Use React and Eui to create an event or conference website! This is a template with an example."

Copy link
Owner

@brittanyjoiner15 brittanyjoiner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we're leaving off the favicon because we will make a new one and just replace the favicon.ico file so there's no code changes needed.

Thanks!!

@brittanyjoiner15 brittanyjoiner15 merged commit ece7e3f into brittanyjoiner15:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants