Would there be an advantage to moving the service setups from MainActivity and AppDelegate to the App class constructor?

[rs-mobitech]

I see in the Android MainActivity and the iOS AppDelegate you have the same code:

        var themeService = ContainerService.Container.Resolve<ThemeService>();
        var languageService = ContainerService.Container.Resolve<LanguageService>();
        var splashScreenPage = ContainerService.Container.Resolve<SplashScreenPage>();
        var analyticsService = ContainerService.Container.Resolve<IAnalyticsService>();
        var notificationService = ContainerService.Container.Resolve<NotificationService>();
        var deviceNotificationsService = ContainerService.Container.Resolve<IDeviceNotificationsService>();

        LoadApplication(new App(themeService, languageService, splashScreenPage, analyticsService, notificationService, deviceNotificationsService));

Would it better if this were moved to the constructor of the App class instead?

Just wondering why you chose to do it this way and if there is any advantage to doing it the way that you did?

[brminnick]

Hey @rscholey!

I don't really have a good reason for this. I guess I could add App to the Dependency Injection Container, here https://github.com/brminnick/GitTrends/blob/main/GitTrends/Services/ContainerService.cs

This would allow the code in both MainActivity and AppDelegate to be condensed to this:

  var app = ContainerService.Container.Resolve<App>();
  LoadApplication(app);

Is this the solution you had in mind?

[rs-mobitech]

Yes, I was thinking either that or just including all of the resolution lines into the App class just so they would be located in the one place as right now you have the same code lines in iOS and Android plus I assume when we move to MAUI it would be better to have that code in the common area.

[brminnick]

Done!

Here's the commit: 2169be0