Feature: Share model publicly #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aria-hidden hide element from screen readers - aria-hidden should be used only if the icons have no semantic value. - Since those icons have a meaning and are important actions to all users, we should no use aria-hidden here
- Add Share model modal - Add translations
- Remove "Back arrow" navigation - Use white background at main .navbar - Add "Create account button" - Remove <status-bar> - Increase .model-area size to cover the entire screen with; - Adjust loading position - Adjust toolbar position
This fix the issue on all model views: Conceptual, Logic and PublicView - Limit width of model name - Add ellipsis to the end opf the line in case of long names - Add title attricute to enable user to see the full name on :hover if needed
In some cases were the model name was too long, it was causing the list layout to break. This commit fiox this issue - Add projectsList.scss - Limit model name width and add ellipsis in case of larger text - Display model full name on :hover with title
Public View Module
…o-app into feature/export-model
- Remove styles from modelWorkspace.scss - Move styles to it's own scss inside the component - Import it at publicView.js - Fix small layout issue related to navbar size on public view
After introduce the icon to represent the model type at the model workspace header, s small aligment bug was introduced to modelSidebar. This commit tweak the magic numbers to fix this issue
…o-app into feature/export-model
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This pull request can only be merged after the following merge requests are merged
Summary
This pull request introduce to BRMW a feature that enable users to generate a public link to their models.
When enabling public share, a unique URL is created. This, any person with the link have view access to that model.
We're introducing a Share button visible at the models list and also at model workspace (Both Conceptual and Logic). When using this entry point, user is exposed to a modal with the option to generate a public link that can bem shared.
This is feature follows the MVP approach, meaning it provide some functionality but theres a lot of room to improvement we may or may not explore depending of users demand.
Important
The shared models only allow view access, meaning people with the link cannot modify it.
Only the owner of the model can modify it using the regular workspace (Not the public view)
Screenshots
Related issues