Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement post endpoint #17

Merged
merged 1 commit into from
May 4, 2015
Merged

Implement post endpoint #17

merged 1 commit into from
May 4, 2015

Conversation

dshiga
Copy link
Contributor

@dshiga dshiga commented May 4, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.77%) to 83.44% when pulling 47e0bb2 on implement_POST into 64f04c9 on master.

@bradtaylor
Copy link
Contributor

Looks good to me!

dshiga pushed a commit that referenced this pull request May 4, 2015
Merge pull request #17 from broadinstitute/implement_POST
2141680 
Implement post endpoint
@dshiga dshiga merged commit 2141680 into master May 4, 2015
@dshiga dshiga deleted the implement_POST branch May 4, 2015 17:34
mcovarr
mcovarr reviewed May 4, 2015
View reviewed changes
src/main/scala/org/broadinstitute/dsde/agora/server/dataaccess/mongo/AgoraMongoDao.scala
@@ -39,7 +39,10 @@ class AgoraMongoDao(collection: MongoCollection) extends AgoraDao {
//insert the entity
val dbEntityToInsert = EntityToMongoDbObject(entity)
collection.insert(dbEntityToInsert)
findSingle(entity)
findSingle(entity) match {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be getOrElse { throw new Exception(...) }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dshiga @coveralls @bradtaylor @mcovarr