Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bt documentation test #26

Merged
merged 2 commits into from
May 8, 2015
Merged

Bt documentation test #26

merged 2 commits into from
May 8, 2015

Conversation

bradtaylor
Copy link
Contributor

Added a test for successful storage of markdown in documentation

To satisfy DSDEEPB-46. Acceptance Criteria:

* There exists a metadata field which can accept a large (10KB) markdown representing tool documentation.
* There exists a unit test that validates that a 10kb string of github markdown is recovered without getting garbled

The metadata field exists. Here I'm adding the test. I made a little md file containing various markdown features.

I am concatenating that until it would be >10kb stored, and sending that through the webservice.

I am doing this the full way through the service, not just as a db test, because I want to make sure serialization/deserialization and spray marshalling etc. do not garble the string.

Only changed total testing time from 5s -> 6s

Also added Agora.stop() back to test suite cleanup.

@@ -11,6 +13,17 @@ trait AgoraTestData {

val documentation = "This is the documentation"

def getbigDocumentation: String = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B should be capitalized

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amusing that a little b was used in the word big

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 85.06% when pulling 1bc1fce on bt_documentation_test into 8f2c5f3 on master.

To satisfy DSDEEPB-46. Acceptance Criteria:
```
* There exists a metadata field which can accept a large (10KB) markdown representing tool documentation.
* There exists a unit test that validates that a 10kb string of github markdown is recovered without getting garbled
```

The metadata field exists. Here I'm adding the test. I made a little md file containing various markdown features.
I am concatenating that until it would be >10kb stored, and sending that through the webservice.

I am doing this the full way through the service, not just as a db test, because I want to make sure
serialization/deserialization and spray marshalling etc. do not garble the string.
This was removed when After was changed to AferAll. Restoring here.
bradtaylor pushed a commit that referenced this pull request May 8, 2015
@bradtaylor bradtaylor merged commit 7bf1b6a into master May 8, 2015
@bradtaylor bradtaylor deleted the bt_documentation_test branch May 8, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants