Fix search and unit tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f failing. Fix some broken tests.
documentation, owner, payload.
|
Looks good. I'm going to merge this so I can start the rebase of the refactor pull request which is bound to get hairy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searches on owner, documentation, synopsis, and payload were failing. I changed the order of fields in AgoraSearch to match those in AgoraEntity and it is now working.
I also fixed the unit tests in ApiServiceSpec. They were erroneously passing because we had statements using === but not wrapped in assert(). So even if the === statements return false, the tests would pass.
Lastly, I added additional unit tests to verify search on owner, documentation, synopsis, and payload.