[DDO-2875] Fix Agora entrypoint so that Agora shuts down #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agora's entrypoint calls a shell script that turns around and runs the jar.
This is very bad practice because bash does not propagate the shutdown SIGTERM signal. This means that Agora never shuts down and runs continuously until the container runtime forcibly kills it.
This means that Agora's shutdown hook never runs. You can check logs for the shutdown hook's "Stopping server" message to see that it never runs. You can also check logs for the Cloud SQL Proxy's "active connections still exist after waiting for 30s" error message, further indicating that the app never shuts down when told to.
This PR adopts the same command as apps like Leonardo and Sam, which propagates the signal.