[DSPDC-1717] Add common job polling code to this lib #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbst-broad
requested review from
a team,
raaidbroad,
eparkmonster and
quazi-h
and removed request for
a team
aherbst-broad
commented
May 24, 2021
| """ | ||
|
|
||
|
|
||
| class JobId(str): |
There was a problem hiding this comment.
This is going to be a common type used everywhere, I thought now is a good time to extract to this lib.
raaidbroad
approved these changes
May 24, 2021
eparkmonster
approved these changes
May 24, 2021
aherbst-broad
force-pushed
the
arh-dspdc-1717-poll
branch
from
15babf3
to
e7b8873
Compare
aherbst-broad
force-pushed
the
arh-dspdc-1717-poll
branch
from
e7b8873
to
1bc1e76
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Relevant ticket
We need to poll on dataset creation for the referenced ticket; we should extract the common polling code to a lib for reuse elsewhere.
This PR
Library Checklist