DDO-1161 Support for regional PDs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choover-broad
changed the title
…dd a simple unit test that mocks the GKE API
…p for now and use default client context
mflinn-broad
requested changes
Apr 2, 2021
mflinn-broad
reviewed
Apr 2, 2021
mflinn-broad
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👶 's first Golang PR!
This PR updates disk-manager to support setting snapshot policies on regional persistent disks. Previously, only zonal disks were supported; but we've decided to use regional PDs for stateful services in prod because they offer more redundancy.
This PR also adds some unit test coverage and refactors the code a bit to support unit testing. The unit tests I added follow the approach described here for testing code that interacts with the K8s API. Httpmock is used to fake/mock GCP API calls.