Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useReferenceDisks as passthrough for SubmissionRequest [CROM-6662] #813

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

breilly2
Copy link
Contributor

@breilly2 breilly2 commented Nov 12, 2020

<your comments for this PR go here>

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

Copy link
Contributor

@kshakir kshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Travis is happy I'm happy

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 64.441% when pulling bdbc512 on br-reference-disks into cd0630e on develop.

@breilly2 breilly2 marked this pull request as ready for review November 13, 2020 15:31
@mcovarr mcovarr changed the title Add useReferenceDisks as passthrough for SubmissionRequest Add useReferenceDisks as passthrough for SubmissionRequest [CROM-6662] Nov 13, 2020
@breilly2 breilly2 merged commit 080afb6 into develop Nov 19, 2020
@breilly2 breilly2 deleted the br-reference-disks branch November 19, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants