-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retire FilterVcf in favor of VariantFiltration? #1215
Comments
WDYT @yfarjoun @ldgauthier ? |
I've never used the Picard one. I'm under the impression that the Picard version actually removes variants from the output, which I am against. |
OK. I looked at the code. They do the same thing. not removing variants, The Picard version was written since GATK was too slow.... On Wed, Dec 2, 2015 at 1:59 PM, ldgauthier notifications@github.com wrote:
|
👍 for fast. |
thanks for clarifying. I'll compare perf of GATK4 and report it here. |
It's true - FilterVCF is faster when filtering genotypes. Here I took 1 small vcf file with 2535 samples and 12632 lines (675M) I'm closing this then. Unclear if we want to invest in speeding up VariantFiltration given that we're moving away from vcf files at some point.
|
One clarification - FilterVCF is not a subset of VariantFiltration, it offers one new option - filter on allele balance computed on the fly. I added #1726 |
FilterVcf seems to be a subset of VariantFiltration. Should we retire it?
The text was updated successfully, but these errors were encountered: