Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PairHMM : don't pass base indel qualities to native code #2036

Open
akiezun opened this issue Jul 22, 2016 · 3 comments
Open

PairHMM : don't pass base indel qualities to native code #2036

akiezun opened this issue Jul 22, 2016 · 3 comments

Comments

@akiezun
Copy link
Contributor

akiezun commented Jul 22, 2016

we don't use indel base qualities anymore in GATK, so this code is creating and passing 2 arrays that are always filled with DEFAULT_INSERTION_DELETION_QUAL=45 for every read. This must be expensive. If the number is needed for the PairHMM, then just pass 45.

@eitanbanks wdyt? are the indel quals needed in the pairhmm?

@droazen
Copy link
Collaborator

droazen commented Mar 22, 2017

Assigning to @gspowley to determine whether this is still an issue.

@droazen droazen added this to the beta milestone Mar 22, 2017
@gspowley
Copy link
Collaborator

It would help performance if we used constants instead of arrays in PairHMM. I'll investigate.

@magicDGS
Copy link
Contributor

But what if indel qualities are set somehow but an user? Will the PairHMM code still consider them if they are not constant, either in the native or pure-java implementation?

@droazen droazen modified the milestones: 4.0 release, beta Apr 3, 2017
@droazen droazen removed this from the Engine-4.0 milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants