Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased maximum copy-ratio variance slice-sampling bound. #3378

Merged
merged 1 commit into from Jul 28, 2017

Conversation

@samuelklee
Copy link
Contributor

samuelklee commented Jul 28, 2017

Just a patch to make the change suggested in the review of broadinstitute/gatk-protected#1001. @asmirnov239 your comment was correct, not sure what I was thinking back then!

Closes #3372.

@samuelklee

This comment has been minimized.

Copy link
Contributor Author

samuelklee commented Jul 28, 2017

@asmirnov239 Not sure why I can't request a review from you through the menu on the top right, but please review.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 28, 2017

Codecov Report

Merging #3378 into master will decrease coverage by 0.003%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #3378       +/-   ##
===============================================
- Coverage     80.498%   80.495%   -0.003%     
  Complexity     17509     17509               
===============================================
  Files           1173      1173               
  Lines          63368     63368               
  Branches        9876      9876               
===============================================
- Hits           51010     51008        -2     
- Misses          8409      8411        +2     
  Partials        3949      3949
Impacted Files Coverage Δ Complexity Δ
...ender/tools/exome/copyratio/CopyRatioModeller.java 92.157% <100%> (ø) 7 <0> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 66.667% <0%> (-3.333%) 10% <0%> (ø)
@asmirnov239

This comment has been minimized.

Copy link
Collaborator

asmirnov239 commented Jul 28, 2017

@samuelklee Looks good! Feel free to merge!

@samuelklee samuelklee merged commit 22d4fa0 into master Jul 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@samuelklee samuelklee deleted the sl_cr_var_slice_bounds branch Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.