New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elapsed time to assembly info in intervals file #3629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Codecov Report
@@ Coverage Diff @@
## master #3629 +/- ##
==============================================
+ Coverage 79.774% 79.784% +0.01%
- Complexity 18235 18238 +3
==============================================
Files 1225 1225
Lines 66978 66983 +5
Branches 10449 10449
==============================================
+ Hits 53431 53442 +11
+ Misses 9324 9318 -6
Partials 4223 4223
|
import org.apache.log4j.Logger; | ||
import org.apache.spark.broadcast.Broadcast; | ||
|
||
public class SparkUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already a SparkUtils.java
living in org.broadinstitute.hellbender.utils.spark
. Maybe this can be moved there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Moved it there, as you suggested.
fba6f1c
to
6c62ea9
Compare
6c62ea9
to
1e5a4f3
Compare
Here's a tiny commit that's mostly just code cleanup. @SHuang-Broad -- I sprinkled some "final"s around.