New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug in which F1R2 and F2R1 annotation kept discarded alleles #3636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3636 +/- ##
==============================================
- Coverage 79.78% 79.521% -0.259%
- Complexity 18237 18606 +369
==============================================
Files 1225 1232 +7
Lines 66983 68558 +1575
Branches 10449 10884 +435
==============================================
+ Hits 53439 54518 +1079
- Misses 9320 9732 +412
- Partials 4224 4308 +84
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be prudent to add/enhance a test that just checks that the number of values is correct? I
@davidbenjamin Can you make a test for this? |
@LeeTL1220 done. I put it in the M2 integration test because it is part of a bigger potential issue, that of phantom alleles from the likelihoods that don't make it into the variant call. Back to you. |
@davidbenjamin Looks good... merge away |
@LeeTL1220 you were right. Fortunately the fix is very simple.