Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default AF for M2 tumor-normal mode; improved M2 STR filter #4690

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

davidbenjamin
Copy link
Contributor

@takutosato The first commit gives tumor-normal the old default AF. The second commit is a more intelligent STR contraction filter that improves both sensitivity and precision.

@davidbenjamin
Copy link
Contributor Author

@takutosato The one test failure occurs because when there is low normal coverage germline risk might get triggered too often. I might need to adjust the default value but it won't affect the code otherwise.

Copy link
Contributor

@takutosato takutosato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #4690 into master will increase coverage by 0.082%.
The diff coverage is 73.333%.

@@               Coverage Diff               @@
##              master     #4690       +/-   ##
===============================================
+ Coverage     79.852%   79.934%   +0.082%     
- Complexity     17336     17432       +96     
===============================================
  Files           1074      1074               
  Lines          62938     63305      +367     
  Branches       10186     10319      +133     
===============================================
+ Hits           50257     50602      +345     
- Misses          8701      8709        +8     
- Partials        3980      3994       +14
Impacted Files Coverage Δ Complexity Δ
...der/tools/walkers/mutect/M2ArgumentCollection.java 94.118% <0%> (-5.882%) 3 <2> (+2)
...ls/walkers/mutect/M2FiltersArgumentCollection.java 100% <100%> (ø) 1 <0> (ø) ⬇️
.../tools/walkers/mutect/SomaticGenotypingEngine.java 89.82% <100%> (ø) 65 <0> (ø) ⬇️
...r/tools/walkers/mutect/Mutect2FilteringEngine.java 82.237% <70%> (-0.64%) 41 <0> (+1)
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)
...lkers/ReferenceConfidenceVariantContextMerger.java 95.5% <0%> (+0.243%) 101% <0%> (+30%) ⬆️
...stitute/hellbender/tools/walkers/CombineGVCFs.java 94.631% <0%> (+0.881%) 61% <0%> (+1%) ⬆️
.../discovery/alignment/ContigAlignmentsModifier.java 88.353% <0%> (+1.158%) 50% <0%> (+5%) ⬆️
...park/sv/discovery/alignment/AlignmentInterval.java 94.402% <0%> (+1.362%) 143% <0%> (+59%) ⬆️

@davidbenjamin davidbenjamin merged commit 36eb37f into master Apr 24, 2018
@davidbenjamin davidbenjamin deleted the db_m2_str branch April 24, 2018 13:57
cwhelan pushed a commit to cwhelan/gatk-linked-reads that referenced this pull request May 25, 2018
…roadinstitute#4690)

* different default AFs for Mutect2 tumor-only and tumor-normal

* improved Mutect2 PCR slippage filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants