Removed instances of String.format to help funcotator performance #7370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonn-smith
requested changes
Jul 27, 2021
| @@ -13,6 +13,7 @@ | |||
| import java.util.LinkedHashSet; | |||
| import java.util.List; | |||
| import java.util.stream.Collectors; | |||
| import org.apache.commons.lang3.StringUtils; | |||
There was a problem hiding this comment.
Looks like this import was added but isn't needed. Can you remove it?
| .collect(Collectors.toList()); | ||
| final List<String> cleanLetters = new ArrayList<>(); | ||
| for(String s: badLetters) { | ||
| String hex = Integer.toHexString(s.getBytes(StandardCharsets.US_ASCII)[0] & 0xFF).toUpperCase(); |
There was a problem hiding this comment.
This is great, but I think you can simplify it into an if statement with one assignment in each branch:
if (s.getBytes(StandardCharsets.US_ASCII)[0] < 16) {
// Need to add leading zero
}
else {
// straight conversion
}
Then you can do one assignment (with a couple of + operations) in each of those conditions.
jonn-smith
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6574