Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultima, New/Updated Features #8579

Merged
merged 23 commits into from Nov 28, 2023

Conversation

dror27
Copy link
Contributor

@dror27 dror27 commented Nov 11, 2023

New: GroundTruthScorer
Update: FlowFeatureMapper

dror27 added 22 commits May 30, 2023 10:50
 the number of reads in the locus that pass the FeatureMap filters, regardless of whether the considered base matches the reference or not
format <name>[,<type>[,<desc>]]. types: Integer, Float, String, Character, Fl

Defaults to type String
Defaults to desc: copy-attr: <name>
added deviation to reports
report to use true base instead of aligned
Fixed hardcoded 12-mer (partial fix)
--add-mean-call parameter added
ReadProbs and ReadMeanCall added

merge changes
- range extended
- clipping implemented
Adding option to omit lines with zero count from report. Note that some initial lines w/ 0 are kept to make sure a table will be output even if empty.

Also better handling of unmapped reads.
@dror27
Copy link
Contributor Author

dror27 commented Nov 28, 2023

@meganshand: I've addressed your comments. Thank you

Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@meganshand meganshand merged commit 0da6409 into broadinstitute:master Nov 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants