Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local copy of VEP configuration #226

Closed
nawatts opened this issue May 14, 2020 · 1 comment · Fixed by #231
Closed

Use local copy of VEP configuration #226

nawatts opened this issue May 14, 2020 · 1 comment · Fixed by #231

Comments

@nawatts
Copy link
Contributor

nawatts commented May 14, 2020

Currently, VEP configuration is downloaded from Hail's US bucket.

VEP_REFERENCE_DATA = {
"GRCh37": {
"vep_config": "gs://hail-us-vep/vep85-loftee-gcloud.json",
"all_possible": "gs://gnomad-public/papers/2019-flagship-lof/v1.0/context/Homo_sapiens_assembly19.fasta.snps_only.vep_20181129.ht",
},
"GRCh38": {
"vep_config": "gs://hail-us-vep/vep95-GRCh38-loftee-gcloud.json",
"all_possible": "gs://gnomad-public/resources/context/grch38_context_vep_annotated.ht",
},
}

This bucket is requestor pays, so reading from it requires that either --requester-pays-allow-all or --requester-pays-allow-buckets hail-us-vep is specified when starting the cluster. If someone isn't aware of that, it's easy to start a cluster (which takes a fair amount of time with VEP) that can't run the gnomAD VEP utilities.

hailctl dataproc's VEP init scripts download these configuration files and link them to /vep_data/vep-gcloud.json. If VEP configuration was loaded from the local copy downloaded by the init scripts instead of the hail-us-vep bucket, then the requestor pays arguments would not be necessary.

https://github.com/hail-is/hail/blob/498f73704368ea548dfcd4acc469c6fbcd61f83a/hail/python/hailtop/hailctl/dataproc/resources/vep-GRCh37.sh#L26-L28

https://github.com/hail-is/hail/blob/498f73704368ea548dfcd4acc469c6fbcd61f83a/hail/python/hailtop/hailctl/dataproc/resources/vep-GRCh38.sh#L26-L28

@lfrancioli
Copy link
Contributor

Makes total sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants