Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gnomAD resources to reflect free Google Cloud-hosted paths #264

Closed
gtiao opened this issue Sep 30, 2020 · 5 comments · Fixed by #431
Closed

Update gnomAD resources to reflect free Google Cloud-hosted paths #264

gtiao opened this issue Sep 30, 2020 · 5 comments · Fixed by #431
Assignees

Comments

@gtiao
Copy link
Contributor

gtiao commented Sep 30, 2020

Prefixes should change from gs://gnomad-public/ or gs://gnomad-public-requester-pays/ to gs://gcp-public-data--gnomad

@nawatts
Copy link
Contributor

nawatts commented Sep 30, 2020

Along with this, we should also remove the gnomad-public-requester-pays bucket from the getting started and VEP docs.

@nawatts
Copy link
Contributor

nawatts commented May 5, 2021

#373 added support for reading resources from the Google Cloud Public Datasets bucket. Do we want to make that the default?

@gtiao
Copy link
Contributor Author

gtiao commented Jun 17, 2021

Need to check that all recent, most updated files are synced to public GCP bucket, and then can proceed.

Nick notes that would be better/ideal to have entire bucket synced to GCP public bucket.

@nawatts
Copy link
Contributor

nawatts commented Jun 17, 2021

A quick check revealed that the public GCP bucket's resources directory only contains the VEP 85 and 95 context Hail Tables.

So most of the reference data resources are not available from that bucket.

@nawatts
Copy link
Contributor

nawatts commented Jun 21, 2021

We could still change the default source to the GCP bucket, if we assume that most users will be interested in the gnomAD resources vs the reference data resources.

#388 will also help with this by adding a more informative error message when a resource is not available from the selected source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment