This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
approved these changes
Sep 1, 2017
implicit class MapErrorOrRhs[A, B](val m: Map[A, ErrorOr[B]]) extends AnyVal { | ||
private def elementToErrorOr(kvp: (A, ErrorOr[B])): ErrorOr[(A, B)] = kvp._2 map { v => (kvp._1, v) } | ||
|
||
def sequence: ErrorOr[Map[A, B]] = m.toList.traverse[ErrorOr, (A, B)] { x => elementToErrorOr(x) } map { _.toMap } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToL could you implement traverse
and have sequence
be a special case that applies identity
to the elements?
b228d6b
to
16c23b7
Compare
@mcovarr is this what you intended? |
You should get |
@danbills I wasn't able to get that to work, even with |
@cjllanwarne I wasn't either, but I was able to get it to work in Cats console... Investigating cats:
lenthall:
|
danbills
approved these changes
Sep 11, 2017
16c23b7
to
83dd230
Compare
83dd230
to
4685329
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.