Added backup_workspace function
#30
Conversation
|
@SHuang-Broad I didn't test this yet - but I wanted to get your feedback on it. What's the best way to do testing? |
There was a problem hiding this comment.
Hey Jonn, I don't think I can review this throughly before my vacation.
A high-level comment is I see you have bare calls to FISS APIs.
I try to wrap all calls to FISS via this
lrma-cloud-utils/src/lrmaCU/utils.py
Line 52 in f97c09a
This makes calls more resilient.
Regarding how to test this, I admit I test things with real workspaces (hence #1 ).
So if you have battle-tested this, that's good. Otherwise I'd prefer this new function to be tested in some workspaces.
| @@ -22,6 +22,18 @@ def get_workspace_bucket(ns: str, ws: str, max_attempts: int = 2) -> str: | |||
| return _query_workspace(ns, ws, max_attempts)['bucketName'] | |||
|
|
|||
|
|
|||
| def get_workspace_attributes(ns: str, ws: str, max_attempts: int = 2) -> dict[str, str]: | |||
There was a problem hiding this comment.
I'd suggest rename this function a bit (sorry for naming the existing one sub-optimally).
get_workspace_all_attributes to avoid (easy to make) typos
|
No worries. This isn't critical to get it, but it would be nice. I'll add some tests in a workspace and we can go over it again when you get back. |
Added the
backup_workspacefunction, which will back up the contents of a workspace to a given bucket.