-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set output_folder to path outside of ml repo #201
Comments
A current workaround for this is to manually signal the output folder to
would mount I agree that realizing that the results are gone only after the run is complete is a bit annoying. I'll see if we can at least release a warning when the user is running the risk of this happening. Also, saving output results outside the repo is a good practice, as it makes startup time faster, so we should encourage it by making it easier. |
Thanks for the workaround, I will try to use that for now! |
Paolo, in your example above, did you mean to suggest mounting the same directory as the user specifies for
rather than:
I did the former and it worked! |
You're absolutely right, Erik, sorry for the typo! |
Ok thanks -- I know it seems like a silly question but I know so little about Docker I wanted to be sure! |
@paolodi I am not sure exactly what changed, but I no longer have to use |
What
When calling
recipes.py
, if a user sets an--output_folder
path that is not within the repo directory, no results are saved on the host machine.It would be great if a user could specify any path on their machine in which to save results from running ML4CVD!
Why
The repo should contain code. Results should live in a different directory. Results in the repo directory can clutter the output of
git status
and subsequent adds, commits, and pushes. Having to move results out of the repo directory adds a step to user workflow.How
I think this limitation is due to a Docker mount setting. The solution is probably to mount the home directory, and accept a limitation that
--output_folder
must be within~/
and not upstream of that. Mounting/
seems problematic.Acceptance Criteria
User can set any
--output_folder
regardless of whether it is in the repo directory, and results appear in a subdirectory specified byid
arg.The text was updated successfully, but these errors were encountered: