Siamese networks #69
Merged
Siamese networks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiamant
approved these changes
Oct 24, 2019
Comment on lines
-96
to
103
| if mixup_alpha > 0 and keep_paths: | ||
| if siamese and keep_paths: | ||
| yield _make_batch_siamese(in_batch, out_batch) + (paths_in_batch,) | ||
| elif siamese: | ||
| yield _make_batch_siamese(in_batch, out_batch) | ||
| elif mixup_alpha > 0 and keep_paths: | ||
| yield _mixup_batch(in_batch, out_batch, mixup_alpha) + (paths_in_batch[:batch_size//2],) | ||
| elif mixup_alpha > 0: | ||
| yield _mixup_batch(in_batch, out_batch, mixup_alpha) |
There was a problem hiding this comment.
This logic is starting to get messy. I wonder if there is any way to clean it up.
There was a problem hiding this comment.
Yeah I think the pattern here is an on_batch_full callback which could handle siamese nets, mixup and data augmentation. Unfortunately, Keras chokes when the generator yields paths but it is a really helpful option for evaluation, outlier plots and debugging
lucidtronix
added a commit
that referenced
this pull request
Jan 13, 2023
* siamese models with random categorical task verification
lucidtronix
added a commit
that referenced
this pull request
Jan 13, 2023
* siamese models with random categorical task verification
lucidtronix
added a commit
that referenced
this pull request
Jan 13, 2023
* siamese models with random categorical task verification
lucidtronix
added a commit
that referenced
this pull request
Jan 13, 2023
* siamese models with random categorical task verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still can't get the inner model to expand in the architecture diagram but oh well.
