update qc section of recipe #72
Conversation
| @@ -164,31 +166,30 @@ | |||
| .reset_index() | |||
| .rename(columns={0: "Ratio"}) | |||
| ) | |||
|
|
|||
| empty_df=empty_df[['Percent_Empty']].stack().to_frame().reset_index().rename(columns={0: "Percent Empty"}) | |||
There was a problem hiding this comment.
I am not sure how else you are using empty_df, but if possible, you should try to keep data processing of a single variable all in one spot. What I mean is move this line closer to where you define empty_df (line 155).
This will help reader understanding a lot.
| + gg.coord_fixed() | ||
| + gg.geom_point(gg.aes(fill="Ratio"), shape='s', size=6) | ||
| + gg.geom_text(gg.aes(label="site_location"), size=6, color="lightgrey") | ||
| + gg.facet_wrap("~cell_quality_recode + well", ncol = 3, scales="fixed") |
There was a problem hiding this comment.
please make sure to run black on this script.
(Black will make sure there are no spaces in ncol=3 😄 )
There was a problem hiding this comment.
hahaha. I can't even count the number of times I told myself "run black before making the PR" and yet I still forgot!
| + gg.theme( | ||
| axis_text=gg.element_blank(), | ||
| axis_title=gg.element_blank(), | ||
| strip_background=gg.element_rect(colour="black", fill="#fdfff4"), | ||
| strip_background=gg.element_rect(colour="black", fill="#fdfff4", height = 1/5), |
| @@ -291,42 +347,40 @@ | |||
| # Any point too high or too low may have focus issues | |||
| pll_col_prefix = "ImageQuality_PowerLogLogSlope_" | |||
| PLLS_df_cols = image_meta_col_list.copy() | |||
| PLLS_cols = [] | |||
| for name in painting_image_names: | |||
There was a problem hiding this comment.
Just confirming that you no longer create a figure for all painting_image_names. Instead you are creating a single figure, correct?
There was a problem hiding this comment.
I don't think painting_image_names was ever used to make separate figures? Yes, this is a single figure for all the painting images.
|
@gwaygenomics Did a little more cleanup.
|
|
very nice - please merge when you are ready. (I assume you have write access) |
Updates QC section including:
Major changes:
Minor changes: