Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with cromwell dependencies #161

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Conversation

abaumann
Copy link
Contributor

similar fix to
broadinstitute/cromwell#236

  • Submitter: Rebase to master. DO NOT SQUASH
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: Make sure documentation for code is complete
  • Submitter: Review code comments; remove done TODOs, create stories for remaining TODOs
  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Add description or comments on the PR explaining the hows/whys (if not obvious)
  • Submitter: Assign PR to
  • : does a once-over of the PR
  • : Anoint a lead reviewer (LR). Assign PR to LR
  • LR: Initial review by LR and others.
  • Comment / review / update cycle:
    • Rest of team may comments on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter updates documentation as needed
    • Submitter rebases to master again if necessary
    • Submitter makes further commits. DO NOT SQUASH. Reassign to LR for further feedback
  • LR: sign off, assign to submitter to finalize
  • Submitter: Squash commits, rebase if necessary
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Merge to master
  • Submitter: Delete branch after merge
  • Submitter: Check configuration files in Jenkins in case they need changes
  • Submitter: Verify swagger UI on dev server still works after deployment
  • Submitter: Inform other teams of any API changes via hipchat and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@jmthibault79
Copy link
Contributor

👍

1 similar comment
@dvoet
Copy link
Contributor

dvoet commented Oct 13, 2015

👍

abaumann added a commit that referenced this pull request Oct 14, 2015
@abaumann abaumann merged commit 1a1934b into master Oct 14, 2015
@abaumann abaumann deleted the ab_sbt_dependency_fix branch March 11, 2016 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants