-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-ticket] remove flaky DataAccessSpec test #1763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I am in favor of removing this flakey test.
IF we decide to remove this, I believe the |
Good call about the config. I'll look into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehigham I dug a bit and I believe this test was written to guard against slick/slick#1274. A fix for that issue was released in Slick 3.2.0. Since we are now on 3.3.2 I believe it is safe to remove this test.
Thank you for digging! |
This performance test doesnt seem to verify behaviour in any of our code and is causing a lot of test failures in PRs. I propose we drop the test.
dev
and
alpha
DBs in Google Cloud Console