[no-ticket] remove flaky DataAccessSpec test

[ehigham]

This performance test doesnt seem to verify behaviour in any of our code and is causing a lot of test failures in PRs. I propose we drop the test.

• Submitter: Include the JIRA issue number in the PR description
• Submitter: Check that the Product Owner has signed off on any user-facing changes
• Submitter: Make sure Swagger is updated if API changes
  • ...and Orchestration's Swagger too!
• Submitter: If updating admin endpoints, also update firecloud-admin-cli
• Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
• Submitter: JIRA ticket checks:
  • Acceptance criteria exists and is met
  • Note any changes to implementation from the description
  • To Demo flag is set
  • Release Summary is filled out, if applicable
  • Add notes on how to QA
• Submitter: Update RC_XXX release ticket with any config or environment changes necessary
• Submitter: Database checks:
  • If PR includes new or changed db queries, include the explain plans in the description
  • Make sure liquibase is updated if appropriate
  • If doing a migration, take a backup of the
    dev
    and
    alpha
    DBs in Google Cloud Console
• Submitter: Update FISMA documentation if changes to:
  • Authentication
  • Authorization
  • Encryption
  • Audit trails
• Tell your tech lead (TL) that the PR exists if they want to look at it
• Anoint a lead reviewer (LR). Assign PR to LR

• Review cycle:
  • LR reviews
  • Rest of team may comment on PR at will
  • LR assigns to submitter for feedback fixes
  • Submitter rebases to develop again if necessary
  • Submitter makes further commits. DO NOT SQUASH
  • Submitter updates documentation as needed
  • Submitter reassigns to LR for further feedback

• TL sign off
• LR sign off
• Assign to submitter to finalize
• Submitter: Verify all tests go green, including CI tests
• Submitter: Squash commits and merge to develop
• Submitter: Delete branch after merge
• Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
• Submitter: Verify swagger UI on dev environment still works after deployment
• Submitter: Inform other teams of any API changes via Slack and/or email
• Submitter: Mark JIRA issue as resolved once this checklist is completed

[aherbst-broad]

lgtm, I am in favor of removing this flakey test.

[davidangb]

IF we decide to remove this, I believe the mysql-low-thread-count db config is no longer used, and should be cleaned up as well. I'd also suggest with whoever wrote/knows about this test to see about its usefulness

[ehigham]

IF we decide to remove this, I believe the mysql-low-thread-count db config is no longer used, and should be cleaned up as well. I'd also suggest with whoever wrote/knows about this test to see about its usefulness

Good call about the config. I'll look into that.
I believe @jmthibault79 wrote this test?

[davidangb]

@ehigham I dug a bit and I believe this test was written to guard against slick/slick#1274. A fix for that issue was released in Slick 3.2.0. Since we are now on 3.3.2 I believe it is safe to remove this test.

[ehigham]

@ehigham I dug a bit and I believe this test was written to guard against slick/slick#1274. A fix for that issue was released in Slick 3.2.0. Since we are now on 3.3.2 I believe it is safe to remove this test.

Thank you for digging!