Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new states to submissions #427

Merged
merged 1 commit into from May 17, 2016
Merged

added new states to submissions #427

merged 1 commit into from May 17, 2016

Conversation

MatthewBemis
Copy link
Member

@MatthewBemis MatthewBemis commented May 16, 2016

This is the rawls part of GAWB-651. These three new states will be added to submissions as discussed in the comments here: https://broadinstitute.atlassian.net/browse/GAWB-651

  • Submitter: Rebase to develop. DO NOT SQUASH
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: Make sure documentation for code is complete
  • Submitter: Make sure liquibase is updated if appropriate
  • Submitter: Review code comments; remove done TODOs, create stories for remaining TODOs
  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Add description or comments on the PR explaining the hows/whys (if not obvious)
  • Tell that the PR exists if he wants to look at it (apply requires_doge label)
  • Anoint a lead reviewer (LR). Assign PR to LR
  • LR: Initial review by LR and others.
  • Comment / review / update cycle:
    • Rest of team may comments on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter updates documentation as needed
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH. Reassign to LR for further feedback
  • sign off
  • LR sign off
  • Assign to submitter to finalize
  • Submitter: Squash commits, rebase if necessary
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Check configuration files in Jenkins in case they need changes
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via hipchat and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 77.938% when pulling e4a25595dd5ec416a92e26c07bcf87719cef7a0f on mb_sub_statsuses into b08fae9 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.888% when pulling e4a25595dd5ec416a92e26c07bcf87719cef7a0f on mb_sub_statsuses into b08fae9 on develop.

@dvoet
Copy link
Contributor

dvoet commented May 17, 2016

are we ready to do this yet? The only one that will be in use in bbq will be accepted.

@MatthewBemis
Copy link
Member Author

@dvoet it would allow for the UI portion of this to be done all at once but if we don't care about getting it all done at once then I can get rid of submitting and evaluating for now

@rushtong
Copy link
Member

👍 Code looks good. There are tests that look at some of the other statuses. Do you want to add tests for these new ones?

@rushtong rushtong assigned MatthewBemis and unassigned rushtong May 17, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.888% when pulling 353a7df on mb_sub_statsuses into b08fae9 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.888% when pulling 353a7df on mb_sub_statsuses into b08fae9 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.888% when pulling 353a7df on mb_sub_statsuses into b08fae9 on develop.

@MatthewBemis MatthewBemis merged commit 1a66cf3 into develop May 17, 2016
@MatthewBemis MatthewBemis deleted the mb_sub_statsuses branch June 27, 2016 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants