Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait for Cromwell Label endpoint to return #953

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Don't wait for Cromwell Label endpoint to return #953

merged 1 commit into from
Jun 29, 2018

Conversation

jmthibault79
Copy link
Contributor

@jmthibault79 jmthibault79 commented Jun 26, 2018 •
edited
Loading

Stopgap solution for DataBiosphere/firecloud-app#97 with longer-term fix to follow

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Check that the Product Owner has signed off on any user-facing changes
  • Submitter: Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • To Demo flag is set
    • Release Summary is filled out, if applicable
    • Add notes on how to QA
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Database checks:
    • If PR includes new or changed db queries, include the explain plans in the description
    • Make sure liquibase is updated if appropriate
    • If doing a migration, take a backup of the
      dev
      and
      alpha
      DBs in Google Cloud Console
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Tell your tech lead (TL) that the PR exists if they want to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Assign to submitter to finalize
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Squash commits and merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via Slack and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

jmthibault79
jmthibault79 commented Jun 26, 2018
View reviewed changes
automation/src/test/scala/org/broadinstitute/dsde/test/api/RawlsApiSpec.scala
@@ -208,5 +209,76 @@ class RawlsApiSpec extends FreeSpec with Matchers with Eventually
}

}

"should retrieve metadata with widely scattered sub-workflows in a short time" in {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted from the previous test

davidangb
davidangb reviewed Jun 27, 2018
View reviewed changes
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks good; assuming the test works as planned.

@jmthibault79
Copy link
Contributor Author

on hold pending decisions

@jmthibault79 jmthibault79 reopened this Jun 28, 2018
davidangb
davidangb approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmthibault79
Copy link
Contributor Author

jenkins restart

@jmthibault79
Copy link
Contributor Author

jenkins retest

@jmthibault79
Copy link
Contributor Author

Jenkins failures are all spurious "GPAlloc project already exists"
https://fc-jenkins.dsp-techops.broadinstitute.org/job/firecloud-ui-fiab-test-runner/4184/consoleFull

gdlex4015
gdlex4015 approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@gdlex4015 gdlex4015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our conversation, please improve the text of an error message displayed to users

@jmthibault79 jmthibault79 merged commit 9c5ff47 into develop Jun 29, 2018
@jmthibault79 jmthibault79 deleted the jt_fc_97 branch June 29, 2018 15:28
jmthibault79 added a commit that referenced this pull request Jul 9, 2018
@jmthibault79
Revert "Cromwell labeling is a slow process so don't wait for it (#953)"
25b3ca1 
This reverts commit 9c5ff47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidangb davidangb davidangb approved these changes

@gdlex4015 gdlex4015 gdlex4015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jmthibault79 @davidangb @gdlex4015