add unit test for case insensitive group memberships (#172)

* add unit test for case insensitive group memberships

* more proper fix

src/main/scala/org/broadinstitute/dsde/workbench/sam/directory/LdapDirectoryDAO.scala

@@ -105,8 +105,8 @@ class LdapDirectoryDAO(protected val ldapConnectionPool: LDAPConnectionPool, pro
       entry <- Option(ldapConnectionPool.getEntry(subjectDn(member), Attr.memberOf))
       memberOf <- Option(entry.getAttribute(Attr.memberOf))
     } yield {
-      val memberships = memberOf.getValues.toSet.map(dnToGroupIdentity)
-      memberships.contains(groupId)
+      val memberships = memberOf.getValues.map(_.toLowerCase).toSet //toLowerCase because the dn can have varying capitalization
+      memberships.contains(groupDn(groupId).toLowerCase)
     }
     isMember.getOrElse(false)
   }

src/test/scala/org/broadinstitute/dsde/workbench/sam/directory/LdapDirectoryDAOSpec.scala

@@ -368,6 +368,19 @@ class LdapDirectoryDAOSpec extends FlatSpec with Matchers with TestSupport with
     assert(runAndWait(dao.isGroupMember(policy1.id, userId)))
   }
 
+  it should "be case insensitive when checking for group membership" in {
+    val userId = WorkbenchUserId(UUID.randomUUID().toString)
+    val user = WorkbenchUser(userId, WorkbenchEmail("foo@bar.com"))
+
+    val groupName1 = WorkbenchGroupName(UUID.randomUUID().toString)
+    val group1 = BasicWorkbenchGroup(groupName1, Set(userId), WorkbenchEmail("g1@example.com"))
+
+    runAndWait(dao.createUser(user))
+    runAndWait(dao.createGroup(group1))
+
+    assert(runAndWait(dao.isGroupMember(WorkbenchGroupName(group1.id.value.toUpperCase), userId)))
+  }
+
   it should "get pet for user" in {
     val userId = WorkbenchUserId(UUID.randomUUID().toString)
     val user = WorkbenchUser(userId, WorkbenchEmail("foo@bar.com"))