will this wait for Future?

broadinstitute · Dec 17, 2018 · da14aec · da14aec
1 parent 35dc3ba
commit da14aec
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/scala/org/broadinstitute/dsde/workbench/sam/service/ResourceService.scala b/src/main/scala/org/broadinstitute/dsde/workbench/sam/service/ResourceService.scala
@@ -364,13 +364,13 @@ class ResourceService(
     }
 
   def addSubjectToPolicy(policyIdentity: FullyQualifiedPolicyId, subject: WorkbenchSubject): Future[Unit] =
-    directoryDAO.addGroupMember(policyIdentity, subject).unsafeToFuture().map(_ => ()) andThen {
-      case Success(_) => fireGroupUpdateNotification(policyIdentity)
+    directoryDAO.addGroupMember(policyIdentity, subject).unsafeToFuture().map(_ => ()) flatMap {
+      _ => fireGroupUpdateNotification(policyIdentity)
     }
 
   def removeSubjectFromPolicy(policyIdentity: FullyQualifiedPolicyId, subject: WorkbenchSubject): Future[Unit] =
-    directoryDAO.removeGroupMember(policyIdentity, subject).void.unsafeToFuture() andThen {
-      case Success(_) => fireGroupUpdateNotification(policyIdentity)
+    directoryDAO.removeGroupMember(policyIdentity, subject).void.unsafeToFuture() flatMap {
+      _ => fireGroupUpdateNotification(policyIdentity)
     }
 
   private[service] def loadAccessPolicyWithEmails(policy: AccessPolicy): IO[AccessPolicyMembership] = {