Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests - set DIRECTORY_URL and DIRECTORY_PASSWORD in build script to avoid def… #183

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

jacmrob
Copy link
Contributor

@jacmrob jacmrob commented Jul 17, 2018

…ining them in jenkins (their defaults are not secret

<your comments for this PR go here>

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

…ining them in jenkins (their defaults are not secret
@coveralls
Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 1777

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.355%

Totals Coverage Status
Change from base Build 1771: 0.0%
Covered Lines: 1161
Relevant Lines: 1674

💛 - Coveralls

@jacmrob
Copy link
Contributor Author

jacmrob commented Jul 17, 2018

tested via building sam

@jacmrob jacmrob merged commit f386b0f into develop Jul 17, 2018
@jacmrob jacmrob deleted the jr-move-constants-out-of-jenkins branch July 17, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants